Init entity from ociremote when signing a digest ref #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the object used to seed the SignedEntity used when signing a digest reference to fix a bug where cosign would wipe out all signatures from the manifest (and not garbage-collecting previous signature layers) Before the entity was created from a `ociempty.SignedImage`. This cuased cosign to always wipe any previous signatures attached to the image. Now, cosign el init the entity from a `ociremote.SignedEntity` which will append new signatures to any existing ones. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #1616 +/- ##
==========================================
- Coverage 28.01% 27.95% -0.07%
==========================================
Files 137 137
Lines 7802 7826 +24
==========================================
+ Hits 2186 2188 +2
- Misses 5386 5407 +21
- Partials 230 231 +1
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Mar 16, 2022
coyote240
pushed a commit
to coyote240/cosign
that referenced
this pull request
Mar 16, 2022
This commit modifies the object used to seed the SignedEntity used when signing a digest reference to fix a bug where cosign would wipe out all signatures from the manifest (and not garbage-collecting previous signature layers) Before the entity was created from a `ociempty.SignedImage`. This cuased cosign to always wipe any previous signatures attached to the image. Now, cosign el init the entity from a `ociremote.SignedEntity` which will append new signatures to any existing ones. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
This commit modifies the object used to seed the SignedEntity used when signing a digest reference to fix a bug where cosign would wipe out all signatures from the manifest (and not garbage-collecting previous signature layers) Before the entity was created from a `ociempty.SignedImage`. This cuased cosign to always wipe any previous signatures attached to the image. Now, cosign el init the entity from a `ociremote.SignedEntity` which will append new signatures to any existing ones. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the object used to seed the SignedEntity used when signing a digest reference to fix a bug where cosign would wipe out all signatures from the manifest (and thus, not garbage-collecting previous signature layers) when signing a digest reference.
Before, the entity was created from a
ociempty.SignedImage. This caused cosign to create a new manifest on every invocation ofcosign sign image@sha...., effectively wiping any previous signatures attached to the image.Now, cosign el init the entity from a
ociremote.SignedEntitywhich will append new signatures to any existing ones.Signed-off-by: Adolfo García Veytia (Puerco) puerco@chainguard.dev
Ticket Link
Release Note